Build all of KDE Connect in CI
ClosedPublic

Authored by nicolasfella on Jul 27 2018, 7:37 AM.

Details

Summary

KDE Connect has some code hidden behind CMake flags disabled by default that should be built as well
in CI

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Jul 27 2018, 7:37 AM
nicolasfella created this revision.

Question I have is why these are disabled by default?

Those guard experimental code that is not ready for public yet

bcooksley accepted this revision.Jul 27 2018, 9:24 AM

Seems reasonable enough.

This revision is now accepted and ready to land.Jul 27 2018, 9:24 AM
This revision was automatically updated to reflect the committed changes.