Differential D14410

EDID parsing: strings are up to 13 bytes
ClosedPublic
Actions

Authored by gladhorn on Jul 26 2018, 7:43 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R110:c66291ec8307: EDID parsing: strings are up to 13 bytes
Summary

The descriptor blocks with strings come every 18 bytes,
5 are the header, e.g. for the model:
[0x00 0x00 0x00 0xFC 0x00] followed by the data (13 bytes).

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 26 2018, 7:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 26 2018, 7:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 26 2018, 7:43 PM
broulik accepted this revision.Jul 27 2018, 10:12 AM
broulik added a subscriber: broulik.

According to Wikipedia [1] we have 57-71, 72-89, 90-107, 108-125 (18 each, of which 5 are "the header", so this makes 13)

[1] https://en.wikipedia.org/wiki/Extended_Display_Identification_Data#EDID_1.4_data_format

This revision is now accepted and ready to land.Jul 27 2018, 10:12 AM
Closed by commit R110:c66291ec8307: EDID parsing: strings are up to 13 bytes (authored by gladhorn). · Explain WhyJul 27 2018, 12:16 PM
This revision was automatically updated to reflect the committed changes.
gladhorn added a comment.Jul 27 2018, 12:16 PM

Yes, my laptop screen uses all 13 bytes, that's how I noticed (the model had one character cut off and I happened to debug and see that it was there, so I did the math :)).

Revision Contents
Changeset List

PathPackages
Msrc/edid.cpp (4 lines)

Diff 38580

View Options

src/edid.cpp

Loading...