Differential D14405

Use short pnp id as fallback when the DB file is not found
Needs RevisionPublic
Actions

Authored by gladhorn on Jul 26 2018, 5:48 PM.

Details

Reviewers
davidedmundson
Summary

At least on arch linux pnp.ids does not even exist (while usb.ids and pci.ids do).
There seem to be different sources for these files, so that's something to investigate.

Diff Detail

Repository
R110 KScreen Library
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1225
Build 1239: arc lint + arc unit
gladhorn created this revision.Jul 26 2018, 5:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 26 2018, 5:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 26 2018, 5:48 PM
davidedmundson requested changes to this revision.Jul 27 2018, 10:28 AM
davidedmundson added a subscriber: davidedmundson.

Where vendor is used in the output display we do:

text: ...
      } else if (root.output.edid && root.output.edid.vendor) {
        return root.output.edid.vendor;
      } else {
        return root.output.name;
      }

same for in utils.cpp

Adding a fallback here, will effectively break the fallback used later.

This revision now requires changes to proceed.Jul 27 2018, 10:28 AM
gladhorn added a comment.Jul 27 2018, 12:38 PM

Good catch, I'll have to look into it, right now I get an empty string for both.

gladhorn added a comment.Jul 27 2018, 2:16 PM

I think the qml code should not do logic fiddling with the EDID :) but needs investigation.

Revision Contents
Changeset List

PathPackages
Msrc/edid.cpp (3 lines)

Diff 38520

View Options

src/edid.cpp

Loading...