Differential D14394

Compare UDS entry times directly instead of going through KFileItem
ClosedPublic
Actions

Authored by broulik on Jul 26 2018, 7:40 AM.

Details

Reviewers
elvisangelaccio
dfaure
jtamate
Group Reviewers
Dolphin
Commits
R318:6d011e97305c: Compare UDS entry times directly instead of going through KFileItem
Summary

This avoids creating a QDateTime object with all the timezone processing that comes with it since we're only interested in the relative order, not absolute precise date time values.

Test Plan

Sort order seems identical to before, opening a folder with a gazillion files and sorting by modification time is 12x faster here.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 26 2018, 7:40 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJul 26 2018, 7:40 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Jul 26 2018, 7:40 AM
jtamate added a comment.Jul 26 2018, 7:53 AM

+2 from my part.
I was about to increment KFileItem to return that information also as long long.

dfaure accepted this revision.Jul 26 2018, 8:13 AM

Nice idea.

This revision is now accepted and ready to land.Jul 26 2018, 8:13 AM
Closed by commit R318:6d011e97305c: Compare UDS entry times directly instead of going through KFileItem (authored by broulik). · Explain WhyJul 26 2018, 8:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kitemviews/kfileitemmodel.cpp (8 lines)

Diff 38478

View Options

src/kitemviews/kfileitemmodel.cpp

Loading...