Improve the discoverability of the Filter Text plugin and its menu item
ClosedPublic
Actions

Authored by ngraham on Jul 26 2018, 5:13 AM.

Details

Reviewers

dhaumann
cullmann

Group Reviewers

Kate

Commits

R40:25879726e1ff: Improve the discoverability of the Filter Text plugin and its menu item

Summary

The "Filter Text" plugin is one of Kate's most useful plugins for serious professional use, but it's rather hidden behind a nondescript name, caption, and menu item.

This patch improves the caption to mention "terminal commands" to give a hint about its true power, and also uses a compact variant of that same terminology for the menu item. These changes should improve discoverability.

BUG: 396864
FIXED-IN: 18.12.0

Test Plan

More descriptive caption in the plugins list:

More descriptive menu item text:

Diff Detail

Repository

R40 Kate

Branch

make-filter-text-plugin-more-discoverable (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1220
Build 1234: arc lint + arc unit

ngraham created this revision.Jul 26 2018, 5:13 AM

Restricted Application added a project: Kate. · View Herald TranscriptJul 26 2018, 5:13 AM

Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript

ngraham requested review of this revision.Jul 26 2018, 5:13 AM

Harbormaster completed remote builds in B1198: Diff 38467.Jul 26 2018, 5:13 AM

ngraham edited the summary of this revision. (Show Details)Jul 26 2018, 5:15 AM

ngraham edited the test plan for this revision. (Show Details)

Please adapt the Text Filter plugin in the plugins.docbook https://cgit.kde.org/kate.git/tree/doc/kate/plugins.docbook and
remove the comment "" in line 2887

Update docbook accordingly

Restricted Application added a project: Documentation. · View Herald TranscriptJul 26 2018, 1:48 PM

Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript

Harbormaster completed remote builds in B1220: Diff 38511.Jul 26 2018, 1:48 PM

dhaumann added inline comments.Jul 26 2018, 9:33 PM

doc/kate/plugins.docbook
2884	...be copied... I think a be is missing here.

ngraham marked an inline comment as done.Jul 26 2018, 10:40 PM

Fix embarrassing error

Harbormaster completed remote builds in B1231: Diff 38536.Jul 26 2018, 10:40 PM

All good now?

Ok with me.

BTW, has the text filter plug-in also have a command line command (F7)?

This revision is now accepted and ready to land.Jul 29 2018, 5:38 AM

Ok with me, too.
A command for F7 would be nice.

cullmann accepted this revision.Jul 29 2018, 10:14 AM

Closed by commit R40:25879726e1ff: Improve the discoverability of the Filter Text plugin and its menu item (authored by ngraham). · Explain WhyJul 30 2018, 10:28 PM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			doc/kate/plugins.docbook (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38467	2202580		Jul 26 2018, 5:13 AM	★	★
Diff 2	38511	2202580	Update docbook accordingly	Jul 26 2018, 1:48 PM	★	★
Diff 3	38536	2202580	Fix embarrassing error	Jul 26 2018, 10:40 PM	★	★
Diff 4	38812	240833b	R40:25879726e1ff4c049c5fc5b97ae676f6e983e175	Jul 30 2018, 10:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ca6b92fa9e6d	0e39121300ee	22025804ea0a	Nathaniel Graham	Improve the discoverability of the Filter Text plugin and its menu item (Show More…)	Jul 26 2018, 5:05 AM

Diff 38511

View Options