Optimise setting up the palette
ClosedPublic
Actions

Authored by apol on Jul 26 2018, 1:56 AM.

Details

Reviewers

Commits

R169:c56e3e06729a: Optimise setting up the palette

Summary

For every setBrush/setColor we're initialising a new QBrush instance that
allocates some space in memory. At the moment we were creating and destroying
QBrush instances like crazy, this check aloen saves 23K calls only starting
Discover.

Test Plan

Tried with Discover, KAlgebra and Kirgami Gallery

Diff Detail

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Jul 26 2018, 1:56 AM

Restricted Application added a project: Kirigami. · View Herald TranscriptJul 26 2018, 1:56 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Harbormaster completed remote builds in B1197: Diff 38464.Jul 26 2018, 1:56 AM

apol requested review of this revision.Jul 26 2018, 1:56 AM

remove debug info

Harbormaster completed remote builds in B1271: Diff 38603.Jul 27 2018, 2:06 PM

mart accepted this revision.Jul 27 2018, 2:07 PM

This revision is now accepted and ready to land.Jul 27 2018, 2:07 PM

Closed by commit R169:c56e3e06729a: Optimise setting up the palette (authored by apol). · Explain WhyJul 27 2018, 2:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/libkirigami/platformtheme.cpp (33 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38464	01ce8b3		Jul 26 2018, 1:56 AM	★	★
Diff 2	38603	01ce8b3	remove debug info	Jul 27 2018, 2:06 PM	★	★
Diff 3	38611	594eb92	R169:c56e3e06729ae10396e14a91c6ae6a564571546f	Jul 27 2018, 2:32 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d4bcbe107514	3a9f6926836c	01ce8b3a3ce9	Aleix Pol	Optimise setting up the palette (Show More…)	Jul 26 2018, 1:54 AM

Diff 38611

View Options

src/libkirigami/platformtheme.cpp