Differential D14386

Fix crosshair cursor not showing in red eye reduction tool
ClosedPublic
Actions

Authored by rkflx on Jul 25 2018, 11:19 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:e97eda1df871: Fix crosshair cursor not showing in red eye reduction tool
Summary

RedEyeReductionTool::toolActivated sets Qt::CrossCursor to allow for
more precise positioning where to apply the red eye reduction.

Due to RasterImageView::setCurrentTool calling updateCursor
afterwards, that change is immediately overridden again, though.

By moving around the latter, the issue can be fixed.

BUG: 321933
FIXED-IN: 18.08.0

Test Plan

In View mode, activate the Red Eye Reduction tool. A
crosshair cursor should show, and hide again upon closing the tool.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Jul 25 2018, 11:19 PM
rkflx created this revision.
ngraham accepted this revision.Jul 26 2018, 2:45 AM
ngraham added a subscriber: ngraham.

Ah, so simple! I had worked on a patch for this same issue and suspected it was something like this in here, but couldn't quite figure it out. Nicely done.

This revision is now accepted and ready to land.Jul 26 2018, 2:45 AM
muhlenpfordt added a subscriber: muhlenpfordt.Jul 26 2018, 7:24 AM

Using Ctrl+Left-/Right-Click changes to the closed hand cursor - but that's what you noted before.
Anything else works good. :)

Closed by commit R260:e97eda1df871: Fix crosshair cursor not showing in red eye reduction tool (authored by rkflx). · Explain WhyJul 26 2018, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38527

View Options

lib/documentview/rasterimageview.cpp

Loading...