Fix FINISH_AT management in Scheduler.
ClosedPublic
Actions

Authored by TallFurryMan on Jul 25 2018, 8:40 PM.

Details

Reviewers

Commits

R321:fc5b8e237f68: Fix FINISH_AT management in Scheduler.

Summary

Check light frame presence when opening sequence files.
Remove light frame check from imaging duration estimation.
Fix unexpected completion issue on FINISH_AT, which is now obvious.
Fix completion state on FINISH_AT causing a crash.

Test Plan

Tested with various combinations of FINISH_AT jobs.

Diff Detail

Repository

R321 KStars

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

TallFurryMan created this revision.Jul 25 2018, 8:40 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 25 2018, 8:40 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

TallFurryMan requested review of this revision.Jul 25 2018, 8:40 PM

Harbormaster completed remote builds in B1193: Diff 38458.Jul 25 2018, 8:40 PM

mutlaqja accepted this revision.Jul 26 2018, 5:44 AM

This revision is now accepted and ready to land.Jul 26 2018, 5:44 AM

Closed by commit R321:fc5b8e237f68: Fix FINISH_AT management in Scheduler. (authored by TallFurryMan, committed by mutlaqja). · Explain WhyJul 26 2018, 5:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/ekos/scheduler/scheduler.cpp (54 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38458	40578b1		Jul 25 2018, 8:40 PM	★	★
Diff 2	38470	40578b1	R321:fc5b8e237f68a5bf5ecb4b59eb24c62b45f7a275	Jul 26 2018, 5:44 AM	★	★

Diff 38470

View Options

kstars/ekos/scheduler/scheduler.cpp