Add PerforceImportMetadataWidget
ClosedPublic

Authored by volden on Jul 25 2018, 7:41 PM.

Details

Reviewers
None
Group Reviewers
KDevelop
Commits
R32:11946ea953db: Add PerforceImportMetadataWidget.
Summary

Add PerforceImportMetadataWidget.

Not all functionality is implemented in this version. A subsequent Differential will contain more (maybe the rest) of the functionality.

The widget makes some very basic tests to
a) See if the perforce client executable is a valid one
b) Test if the specified repository server url is valid
c) Test if the repository contains client workspaces

This patch is dependent on: https://phabricator.kde.org/D14372

and reports to the user if any of the tests fail

Test Plan

In order to test it one needs to:

  1. Make sure that P4CONFIG is exported to the environment KDevelop is running in
  2. Make sure that Perforceplugin is not disabled

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volden created this revision.Jul 25 2018, 7:41 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 25 2018, 7:41 PM
volden requested review of this revision.Jul 25 2018, 7:41 PM
apol added a subscriber: apol.Jul 27 2018, 1:10 PM

I've never used perforce and I guess most of us haven't, I'd say you can just push your changes to it. The patch makes sense overall.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2018, 6:37 PM
This revision was automatically updated to reflect the committed changes.