Simplify Edid::Private::parse gamma
AbandonedPublic

Authored by gladhorn on Jul 25 2018, 1:50 PM.

Details

Reviewers
None
Summary

I do wonder if the division by 100 is right though - and where does the +1 come from?
Please review carefully, this change is more of an open question at the moment.

Diff Detail

Repository
R110 KScreen Library
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1176
Build 1189: arc lint + arc unit
gladhorn created this revision.Jul 25 2018, 1:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 1:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 1:50 PM

I do wonder if the division by 100 is right though - and where does the +1 come from?

In regards to EDID 1.4 data format Wikipedia says:

23 | Display gamma, factory default (range 1.00–3.54), datavalue = (gamma×100)-100 = (gamma−1)×100. If 225, gamma is defined by DI-EXT block.

https://en.wikipedia.org/wiki/Extended_Display_Identification_Data#EDID_1.4_data_format

=> gamma = datavalue / 100 + 1

gladhorn abandoned this revision.Jul 27 2018, 7:56 AM

D14418 is nicer