Differential D14369

When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone
ClosedPublic
Actions

Authored by gladhorn on Jul 25 2018, 1:49 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 25 2018, 1:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 1:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 1:49 PM
broulik added a subscriber: broulik.Jul 27 2018, 10:29 AM

Q_REQUIRED_RESULT isn't documented as public API, is it?

davidedmundson accepted this revision.Jul 27 2018, 10:30 AM
This revision is now accepted and ready to land.Jul 27 2018, 10:30 AM
gladhorn added a comment.Jul 27 2018, 12:17 PM

I'll check, if it's not public API, I'll make it. Thanks for the pointer.

gladhorn added a comment.Jul 27 2018, 12:19 PM

It's been there for ages, it's mentioned in the changelog at least... but actually it seems more common to put the attribute before the function, I'll update with that.

gladhorn updated this revision to Diff 38582.Jul 27 2018, 12:23 PM

Moved Q_REQUIRED_RESULT to the front

Closed by commit R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone (authored by gladhorn). · Explain WhyJul 27 2018, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/edid.h (2 lines)

Diff 38583

View Options

src/edid.h

Loading...