Differential D14368

Let edidDecodeFraction return float
ClosedPublic
Actions

Authored by gladhorn on Jul 25 2018, 1:47 PM.

Details

Reviewers
romangg
Commits
R110:15aa08f36561: Let edidDecodeFraction return float
Summary

All uses of the function are QQuaternion setters which take floats.
This saves a bunch of conversions and should thus be faster. The edid
test shows that the result is unchanged in all digits.

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 25 2018, 1:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 1:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 1:47 PM
romangg requested changes to this revision.Jul 26 2018, 11:38 AM
romangg added a subscriber: romangg.

You use the result var of type float in an addition 10 times. Now the calculation is done with less precision. The git message should state why it's no problem.

This revision now requires changes to proceed.Jul 26 2018, 11:38 AM
gladhorn updated this revision to Diff 38593.Jul 27 2018, 12:46 PM
gladhorn edited the summary of this revision. (Show Details)

arc mangled two patches again :(

romangg accepted this revision.Jul 27 2018, 3:59 PM
This revision is now accepted and ready to land.Jul 27 2018, 3:59 PM
Closed by commit R110:15aa08f36561: Let edidDecodeFraction return float (authored by gladhorn). · Explain WhyJul 27 2018, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/edid.cpp (9 lines)

Diff 38623

View Options

src/edid.cpp

Loading...