[effects/glide] Don't animate the Application Dashboard
ClosedPublic

Authored by zzag on Jul 25 2018, 12:14 PM.

Details

Summary

The Glide effect should not animate the Application Dashboard because
it's not an ordinary application or a dialog. Same applies to Kickoff,
panel popups, etc.

The most obvious solution would be to add "plasmashell plasmashell"
window class to the blacklist, but we still would like to animate some
of plasmashell's windows, for example, Empty Trash Bin confirmation
dialog (if the trash bin icon is on the desktop).

One could notice that the Empty Trash Bin confirmation dialog, Task
Manager Settings window, and other plasmashell's windows that we want
to animate have decorations. So, we can use that as a heuristic.

Test Plan

Opened/closed the Application Dashboard.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 25 2018, 12:14 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 25 2018, 12:14 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 25 2018, 12:14 PM
abetts added a subscriber: abetts.Jul 30 2018, 2:08 PM

+1 I support this idea!

davidedmundson accepted this revision.Aug 11 2018, 10:06 PM
davidedmundson added a subscriber: davidedmundson.

I don't really like this, but we can come up with something better later.

This revision is now accepted and ready to land.Aug 11 2018, 10:06 PM

I don't really like this, but we can come up with something better later.

What would be your objections Dave?

zzag added a comment.Aug 12 2018, 6:43 AM

I don't really like this, but we can come up with something better later.

Frankly, I also don't like this because the glide effect is now a little bit more smarter than it should be(I would like to keep effects as dumb as possible). Yes, it would be great to have something generic for detecting system UI.

This revision was automatically updated to reflect the committed changes.