Use unpretty channel name in speakertest
ClosedPublic

Authored by nicolasfella on Jul 25 2018, 10:56 AM.

Details

Summary

The speaker test did not work when channel names were translated, e.g. "Front Left" => "Vorne Links" because the comparison failed. Using pa_channel_position_to_string instead of pa_channel_position_to_pretty_string hopefully
works better.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 25 2018, 10:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 10:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 25 2018, 10:56 AM
broulik added inline comments.Jul 25 2018, 3:08 PM
src/sink.cpp
100

Can you check this is still correct? It doesn't seem to play any sounds here

nicolasfella added inline comments.Jul 25 2018, 3:34 PM
src/sink.cpp
100

front-left/front-right work for me. Rest is untested because I don't have such fancy hardware.

Just to be sure: Is your sink unmuted/loud enough, correct profile selected?

Can you replace name with "front-left-of-center" and test again?

broulik accepted this revision.Sep 11 2018, 2:50 PM
This revision is now accepted and ready to land.Sep 11 2018, 2:50 PM
This revision was automatically updated to reflect the committed changes.