Differential D14361

Remove unused function
ClosedPublic
Actions

Authored by gladhorn on Jul 25 2018, 10:31 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:ed42cf46ae2c: Remove unused function

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 25 2018, 10:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 10:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 10:31 AM
broulik added a subscriber: broulik.Jul 25 2018, 10:46 AM
broulik added inline comments.
kded/daemon.h
38

Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library

gladhorn added inline comments.Jul 26 2018, 12:49 PM
kded/daemon.h
38

Well, the header is not installed, so the export seems pretty silly.

davidedmundson accepted this revision.Jul 27 2018, 10:10 AM
davidedmundson added a subscriber: davidedmundson.

Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library

ABI changing is only an issue if someone else externally links against this. It's fine here.

This revision is now accepted and ready to land.Jul 27 2018, 10:10 AM
Closed by commit R104:ed42cf46ae2c: Remove unused function (authored by gladhorn). · Explain WhyJul 27 2018, 12:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.h (1 line)
Mkded/daemon.cpp (11 lines)

Diff 38586

View Options

kded/daemon.h

Loading...
View Options

kded/daemon.cpp

Loading...