Differential D14359

Create m_saveTimer lazily
ClosedPublic
Actions

Authored by gladhorn on Jul 25 2018, 10:02 AM.

Details

Reviewers
romangg
Group Reviewers
Plasma
Commits
R104:f4b0d85fe061: Create m_saveTimer lazily
Summary

Making the other timers lazy-initialized is more tricky, so for now just touch the saveTimer.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 25 2018, 10:02 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 10:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 25 2018, 10:02 AM
broulik added a subscriber: broulik.Jul 25 2018, 10:31 AM
broulik added inline comments.
kded/daemon.h
79 ↗(On Diff #38400)

This is now uninitialized initially

romangg requested changes to this revision.Jul 26 2018, 11:26 AM
romangg added a subscriber: romangg.

What @broulik says. It should be fine with the m_changeCompressor being startet in init, but the git message should note this. Also the git message could be a bit more descriptive on what's happening.

This revision now requires changes to proceed.Jul 26 2018, 11:26 AM
gladhorn updated this revision to Diff 38516.Jul 26 2018, 4:30 PM

Initialize m_changeCompressor to nullptr

gladhorn updated this revision to Diff 38517.Jul 26 2018, 4:35 PM
gladhorn retitled this revision from Use inintializers and only create m_saveTimer when needed to Create m_saveTimer lazily.

Only touch saveTimer

romangg accepted this revision.Jul 27 2018, 9:32 AM
This revision is now accepted and ready to land.Jul 27 2018, 9:32 AM
Closed by commit R104:f4b0d85fe061: Create m_saveTimer lazily (authored by gladhorn). · Explain WhyJul 27 2018, 12:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.cpp (12 lines)

Diff 38585

View Options

kded/daemon.cpp

Loading...