Differential D14338

Fix preview widget appearing to scale twice
ClosedPublic
Actions

Authored by davidedmundson on Jul 24 2018, 4:17 PM.

Details

Reviewers
broulik
Commits
R104:5c45d27f00b4: Fix preview widget appearing to scale twice
Summary

It worked when I wrote it against integer scaling, it got broken when
fractional support was added, resulting in it rendering at the wrong
size when the host scaling is non integer.

BUG: 388218

Test Plan

Ran with QT_SCALE_FACTOR=1.5 to simulate the host being at that scale
Opened preview and moved slider
At 1.0 buttons were smaller than the main KCM
At 1.5 buttons looked the same
At 2.0 looked bigger

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jul 24 2018, 4:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2018, 4:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jul 24 2018, 4:17 PM
broulik accepted this revision.Jul 24 2018, 6:16 PM
This revision is now accepted and ready to land.Jul 24 2018, 6:16 PM
Closed by commit R104:5c45d27f00b4: Fix preview widget appearing to scale twice (authored by davidedmundson). · Explain WhyJul 24 2018, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/src/previewwidget.cpp (2 lines)

Diff 38354

View Options

kcm/src/previewwidget.cpp

Loading...