Remove Advanced section from screen config

Authored by gladhorn on Jul 24 2018, 9:59 AM.



There was only one option hidden behind the andvanced section, just have
one line for refresh rate that is visible.

Diff Detail

R104 KScreen
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 24 2018, 9:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2018, 9:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 24 2018, 9:59 AM

Will be useful. Can you make the dropdown items all the same size.

Approved; having a single item under an Advanced section didn't make much sense. Also, in the next patch we can use a nice simple QFormLayout for everything here, which is good because the misalignment of the Resolution ComboBox is driving me bananas! :)

I can play with the drop-down sizes in a follow up change. To keep reviews as easy as possible, I prefer to make minimal changes with less chance of breakage :)
I'm unsure about how wide the combo boxes should be though, taking the full width would make them look weird.

ngraham accepted this revision.Jul 24 2018, 1:00 PM

Don't explicitly mess with the combobox sizes; just use a QFormLayout and let it handle that for you.

This revision is now accepted and ready to land.Jul 24 2018, 1:00 PM

@ngraham fixes the alignement of the combo box, it's unrelated to using a form layout.

This revision was automatically updated to reflect the committed changes.