Only use windows image thumbnailer for ico files
ClosedPublic
Actions

Authored by broulik on Jul 24 2018, 8:13 AM.

Details

Reviewers

dfaure
ngraham

Commits

Summary

It has logic for picking the best matching icon whereras image thumbnailer just takes whatever frame happens to be first

Test Plan

Together with D14308 I get prettier .ico file previews

Before

After

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik requested review of this revision.Jul 24 2018, 8:13 AM

broulik created this revision.

+1, change seems sensible. Works nicely for me with the few .ico files I've got, and nothing else appears to be negatively affected.

This revision is now accepted and ready to land.Jul 24 2018, 1:16 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			thumbnail/imagethumbnail.desktop (2 lines)
M			thumbnail/windowsimagethumbnail.desktop (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38306			Jul 24 2018, 8:10 AM	★	★
Diff 2	38761	ca6f38f	R320:95736e1b43b95101173854557b9493139be8bb9f	Jul 30 2018, 10:12 AM	★	★