Differential D14310

Fixes url whitespaces in epub documents
ClosedPublic
Actions

Authored by gassaf on Jul 23 2018, 9:28 PM.

Details

Reviewers

aacid

Group Reviewers

Okular

Commits

R223:fcf148b75b98: Fixes url whitespaces in epub documents

Summary

libepub can't handle whitespace url encodings. This is why epub documents containing whitespaces urls aren't
displayed correctly. Since libepub doesn't seem to be maintained anymore, it might be better to fix this issue here.

BUG: 334711

Test Plan

Example epubs are in the ticket.

Diff Detail

Repository

R223 Okular

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gassaf created this revision.Jul 23 2018, 9:28 PM

Restricted Application added a project: Okular. · View Herald TranscriptJul 23 2018, 9:28 PM

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

gassaf requested review of this revision.Jul 23 2018, 9:28 PM

Harbormaster completed remote builds in B1102: Diff 38278.Jul 23 2018, 9:28 PM

gassaf added a reviewer: Okular.Jul 23 2018, 9:30 PM

Are we sure this won't break something else?

How hard would be to have an autotest (with files that are not copyrighted/tainted) ?

epub generator unit test added

Harbormaster completed remote builds in B1709: Diff 39469.Aug 11 2018, 6:10 PM

Here you go. I created this epub document via a free software tool called sigil.

aacid accepted this revision.Aug 11 2018, 8:21 PM

This revision is now accepted and ready to land.Aug 11 2018, 8:21 PM

Can you commit this yourself, @gassaf?

Yes he can.

@ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup

In D14310#307943, @aacid wrote:

Yes he can.

@ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup

Thanks Albert! And I see you're right on top. :)

Closed by commit R223:fcf148b75b98: Fixes url whitespaces in epub documents (authored by gassaf). · Explain WhyAug 15 2018, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			generators/epub/CMakeLists.txt (10 lines)
A	M	(bin)	generators/epub/autotests/data/test.epub
A	M		generators/epub/autotests/epubgeneratortest.cpp (84 lines)
M			generators/epub/converter.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38278	1503463		Jul 23 2018, 9:28 PM	★	★
Diff 2	39469	1503463	epub generator unit test added	Aug 11 2018, 6:10 PM	★	★
Diff 3	39800	a7aa8a4	R223:fcf148b75b98462b927da605ca76ee69ada31fd1	Aug 15 2018, 5:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
284822f41350	b244a9ddb5cc	4dedf0c18876	Gilbert Assaf	epub generator unit test added	Aug 11 2018, 6:09 PM
4dedf0c18876	d104029f2940	15034639587d	Gilbert Assaf	Fixes url whitespaces in epub documents (Show More…)	Jul 23 2018, 9:20 PM