Use "edit-delete" icon for buttons which delete data
ClosedPublic

Authored by kossebau on Jul 23 2018, 4:14 PM.

Details

Summary

The "list-remove" icon does not signal the user that the related action
actually will results in non-recoverable data deletion. Removing an item
from a list does not necessarily mean the item is destroyed.

Using "edit-delete" instead makes the deletion effect more obvious to the
user. In the Breeze icon theme this also means the related signal color is
used to point out the nature of the action.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 23 2018, 4:14 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 23 2018, 4:14 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 23 2018, 4:14 PM

If no-one objects, would then push upcoming WE 11/12 August.

aaronpuchert accepted this revision.Aug 6 2018, 10:30 PM
aaronpuchert added a subscriber: aaronpuchert.

What about the custom include paths? Still have a list-remove icon there. They are easy to restore though.

This revision is now accepted and ready to land.Aug 6 2018, 10:30 PM

What about the custom include paths? Still have a list-remove icon there. They are easy to restore though.

In the case of the include path removing a path entry does not feel like one is deleting data, as the string is an existing dir (at least usually). So it is more like adding & removing existing items (the paths) to and from a list.
Surely a corner case, not really decided myself.

((Actually I also would prefer it if for all the cases where this patch replace the "list-remove" icon that the corresponding item creation button/menu entry would get something other than the "list-add", something which makes the process of generating data more visible. Sadly though there is no generic "edit-create" or "edit-new" icon yet in the icon themes. Besides, many special ones ("*-new") in the Breeze theme at least also use a "+" symbol overlay, so keeping the current icon is not too much off right now.))

In the case of the include path removing a path entry does not feel like one is deleting data, as the string is an existing dir (at least usually). So it is more like adding & removing existing items (the paths) to and from a list.

That makes sense, although similar reasoning could apply to the project filter. But I think your change is Ok in that regard. It's really hard to draw the line.

This revision was automatically updated to reflect the committed changes.