Differential D14300

Fix bug where cage transform has messed up display
ClosedPublic
Actions

Authored by scottpetrovic on Jul 23 2018, 2:28 PM.

Details

Reviewers
dkazakov
Group Reviewers
Krita
Summary

fixing this bug... https://bugs.kde.org/show_bug.cgi?id=396788

The warp transform strategy code is also used by the cage transform. This small patch just adds a setter so the class knows what type of transform type is being used. Some of the paint logic shouldn't be used with the cage transform.

Test Plan

started using the transform tool, switched modes between warp and cage and ensured that the display was correct when using them

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic created this revision.Jul 23 2018, 2:28 PM
Restricted Application added a project: Krita. · View Herald TranscriptJul 23 2018, 2:28 PM
scottpetrovic requested review of this revision.Jul 23 2018, 2:28 PM
dkazakov accepted this revision.Jul 23 2018, 2:38 PM

Please change the flag into something like

class KisWarpTransformStrategy
{
...
enum TransformType {
    WARP_TRANSFORM,
    CAGE_TRANSFORM
};

void setTransformType(TransformType type);
...
};

The rest is fine, the patch fixes the bug.

This revision is now accepted and ready to land.Jul 23 2018, 2:38 PM
scottpetrovic closed this revision.Jul 24 2018, 1:15 AM

Updated the patch to use an enum for the variable. I pushed it out and closed the bug

Revision Contents
Changeset List

Diff 38258

View Options

plugins/tools/tool_transform2/kis_cage_transform_strategy.cpp

Loading...
View Options

plugins/tools/tool_transform2/kis_warp_transform_strategy.h

Loading...
View Options

plugins/tools/tool_transform2/kis_warp_transform_strategy.cpp

Loading...