Differential D14298

Fix crash with detach tab / hide tab buttons
ClosedPublic
Actions

Authored by tcanabrava on Jul 23 2018, 1:56 PM.

Details

Reviewers
hindenburg
sandsmark
Group Reviewers
Konsole
Commits
R319:033d293d88f7: Fix crash with detach tab / hide tab buttons
Summary

Lambdas don't auto disconnect. Removing that code also
removed one of Nathan's nitpicks on my code.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jul 23 2018, 1:56 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 23 2018, 1:56 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 23 2018, 1:56 PM
hindenburg accepted this revision.Jul 24 2018, 1:24 AM
This revision is now accepted and ready to land.Jul 24 2018, 1:24 AM
Closed by commit R319:033d293d88f7: Fix crash with detach tab / hide tab buttons (authored by tcanabrava, committed by hindenburg). · Explain WhyJul 24 2018, 1:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainer.cpp (4 lines)

Diff 38279

View Options

src/ViewContainer.cpp

Loading...