Differential D14294

Re-Enable --hide-tabbar and --show-tabbar
ClosedPublic
Actions

Authored by tcanabrava on Jul 23 2018, 11:10 AM.

Details

Reviewers
sandsmark
hindenburg
Group Reviewers
Konsole
Commits
R319:8b377385ab3b: Re-Enable --hide-tabbar and --show-tabbar
Summary

Show tabbar and hide tabbar got lost in the transition to a modern
QTabBar, this re-enables them. These options will override the
current settings if you use --hide-tabbar or --show-tabbar.
Changing these options in the settings will change these settings.

To use the current preferences just start konsole without --hide-tabbar
or --show-tabbar

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jul 23 2018, 11:10 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 23 2018, 11:10 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 23 2018, 11:10 AM
ngraham added a subscriber: ngraham.Jul 23 2018, 3:31 PM
ngraham added inline comments.
src/ViewManager.h
134

containe's -> container's

hindenburg retitled this revision from Re-Enable --hide-tabs and --show-tabs to Re-Enable --hide-tabbar and --show-tabbar.Jul 24 2018, 1:45 AM
hindenburg edited the summary of this revision. (Show Details)
hindenburg added a comment.Jul 24 2018, 2:36 AM

This seems over complex - This can wait if you want to rework when you have time.

src/Application.cpp
426

remove debug

430

remove debug

src/ViewContainer.cpp
150–157

s/tabs/tabbar/g

tcanabrava updated this revision to Diff 38327.Jul 24 2018, 11:34 AM
  • Simplify code for show and hide tabs from arguments
tcanabrava added a comment.Jul 24 2018, 11:36 AM

New code has the same behavior of the new code now, you can launch with --hide-tabbar and then re-enable it from the settings as you could with the old tabbar.
I personally feel that this is a bug, but it's a known behavior, so I'm open for input.

tcanabrava updated this revision to Diff 38329.Jul 24 2018, 11:41 AM
tcanabrava marked 3 inline comments as done.
  • Remove typos and debugs
hindenburg edited the summary of this revision. (Show Details)Jul 24 2018, 1:56 PM
hindenburg accepted this revision.Jul 24 2018, 2:07 PM

Let's leave the old way for now where you can change this in the settings. Thanks

This revision is now accepted and ready to land.Jul 24 2018, 2:07 PM
hindenburg added a comment.Jul 24 2018, 2:10 PM

Can you rebase this please?

tcanabrava added a comment.Jul 24 2018, 2:29 PM

Yes, as soon as I get back home

Em ter, 24 de jul de 2018 às 17:10, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:

hindenburg added a comment. View Revision
https://phabricator.kde.org/D14294

Can you rebase this please?

*REPOSITORY*
R319 Konsole

*BRANCH*
fixShowHideTabBarArgs

*REVISION DETAIL*
https://phabricator.kde.org/D14294

*To: *tcanabrava, Konsole, sandsmark, hindenburg
*Cc: *ngraham, konsole-devel, herrold, maximilianocuria, hindenburg

tcanabrava updated this revision to Diff 38386.Jul 25 2018, 8:02 AM
  • Simplify code for show and hide tabs from arguments
  • Remove typos and debugs
tcanabrava marked an inline comment as done and 3 inline comments as not done.Jul 25 2018, 8:03 AM

rebased on top of master.

Closed by commit R319:8b377385ab3b: Re-Enable --hide-tabbar and --show-tabbar (authored by tcanabrava, committed by hindenburg). · Explain WhyJul 25 2018, 1:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Application.cpp (6 lines)
Msrc/ViewContainer.h (3 lines)
Msrc/ViewContainer.cpp (25 lines)
Msrc/ViewManager.h (23 lines)
Msrc/ViewManager.cpp (11 lines)

Diff 38420

View Options

src/Application.cpp

Loading...
View Options

src/ViewContainer.h

Loading...
View Options

src/ViewContainer.cpp

Loading...
View Options

src/ViewManager.h

Loading...
View Options

src/ViewManager.cpp

Loading...