Differential D1429

show/hide only the search bar and not the pane.
ClosedPublic
Actions

Authored by grebois on Apr 16 2016, 5:29 PM.

Details

Reviewers
mlaurent
bensi
Summary

the search bar is always hidden at launch.
if click on search button then show and hide the search bar
and if the search bar is showed and hidden by the config menu, the state of search button is update.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
grebois updated this revision to Diff 3375.Apr 16 2016, 5:29 PM
grebois retitled this revision from to show/hide only the search bar and not the pane..
grebois updated this object.
grebois edited the test plan for this revision. (Show Details)
grebois added reviewers: mlaurent, bensi.
grebois added a project: KDE PIM: KMail.
mlaurent added inline comments.Apr 19 2016, 12:08 PM
kmail/kmmainwidget.cpp
2539

I don"'t like using actionCollection()->action(...) as it can return a null pointer

> it can crash if we made a typo in name.

Better to store action pointer

grebois updated this revision to Diff 3460.Apr 22 2016, 3:25 PM

don't use actionCollection for execute action

mlaurent added inline comments.Apr 23 2016, 11:27 AM
messagelist/src/pane.h
388

add const at the end of method

grebois updated this revision to Diff 3471.Apr 23 2016, 11:48 AM

const added

mlaurent added inline comments.Apr 25 2016, 1:38 PM
kmail/kmmainwidget.cpp
2539

? why do you add MessageList::Pane::.. ?

3315

same here.

grebois updated this revision to Diff 3513.Apr 25 2016, 1:51 PM

an error on my part , I had not noticed that it worked without
messagelist::pane removed

mlaurent accepted this revision.Apr 26 2016, 5:05 AM
mlaurent edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2016, 5:05 AM
mlaurent closed this revision.Mar 21 2018, 8:40 PM

Revision Contents
Changeset List

Diff 3513

View Options

kmail/kmmainwidget.h

Loading...
View Options

kmail/kmmainwidget.cpp

Loading...
View Options

messagelist/src/pane.h

Loading...
View Options

messagelist/src/pane.cpp

Loading...