Fix Kickoff compact repr size hints in panel
ClosedPublic

Authored by hein on Jul 23 2018, 7:08 AM.

Details

Summary

The old code was copy-pasted from Kicker but the wrong code block;
it was the code path for custom button image mode, not the regular
code path.

BUG:395594

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1089
Build 1102: arc lint + arc unit
hein created this revision.Jul 23 2018, 7:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 23 2018, 7:08 AM
hein requested review of this revision.Jul 23 2018, 7:08 AM
hein updated this revision to Diff 38236.Jul 23 2018, 10:42 AM

Revamp, fix issues pointed out by Kai.

hein updated this revision to Diff 38240.Jul 23 2018, 11:45 AM

One more try

hein updated this revision to Diff 38241.Jul 23 2018, 11:48 AM

Clean up diff

broulik accepted this revision.Jul 23 2018, 12:58 PM
This revision is now accepted and ready to land.Jul 23 2018, 12:58 PM
hein planned changes to this revision.Jul 23 2018, 1:48 PM

After more discussion with Kai this is still not fully what we want. I'll make it better later.

hein updated this revision to Diff 38252.Jul 23 2018, 1:54 PM

Only apply size hint in the perpendicular dimension

This revision is now accepted and ready to land.Jul 23 2018, 1:54 PM
hein requested review of this revision.Jul 23 2018, 1:55 PM
broulik accepted this revision.Jul 23 2018, 1:58 PM

Perfect, thanks.

You're missing return before the Math.min ...

This revision is now accepted and ready to land.Jul 23 2018, 1:58 PM
hein updated this revision to Diff 38287.Jul 24 2018, 5:00 AM

Fix coding style.

hein requested review of this revision.Jul 24 2018, 5:40 AM

One more time Kai, sorry :P

hein updated this revision to Diff 38290.Jul 24 2018, 6:08 AM

Fix one whitespace for making of glorious patch

broulik accepted this revision.Jul 24 2018, 8:03 AM
This revision is now accepted and ready to land.Jul 24 2018, 8:03 AM
This revision was automatically updated to reflect the committed changes.