Differential D14269

Fix image smoothing sometimes not getting applied
ClosedPublic
Actions

Authored by rkflx on Jul 21 2018, 10:50 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:1ce062a458b1: Fix image smoothing sometimes not getting applied
Summary

In View mode, smoothing is applied for scaling up raster images up
to 400%. In general this works fine, but in some cases the smoothing
becomes visible only after zooming manually.

This is due to defaulting to Qt::FastTransformation and switching to
Qt::SmoothTransformation only for changes in the zoom level and for
the Fit/Fill zoom modes, but not when the zoom level is unchanged
when navigating to an image.

The issue can be fixed by calling onZoomChanged, which not only calls
updateBuffer as before, but also setTransformationMode.

BUG: 396736
FIXED-IN: 18.08.0

Test Plan

Enable Image View → Zoom mode → Keep same zoom and position, zoom
in to a zoom level just below 400% and switch to the next image.
Smoothing should be applied immediately, without having to zoom in and
out again.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Jul 21 2018, 10:50 PM
rkflx created this revision.
rkflx added a comment.Jul 21 2018, 10:54 PM

Refactoring sneak peek (headed for master, will post a Diff once the bug fix landed), which still needs testing and a commit message: P243

ngraham accepted this revision.Jul 22 2018, 1:07 PM
ngraham added a subscriber: ngraham.

Explanation makes sense and the patch works as expected.

This revision is now accepted and ready to land.Jul 22 2018, 1:07 PM
muhlenpfordt added a subscriber: muhlenpfordt.Jul 23 2018, 7:04 AM
In D14269#295718, @rkflx wrote:

Refactoring sneak peek (headed for master, will post a Diff once the bug fix landed), which still needs testing and a commit message: P243

Patch and refactoring preview looks both good to me, can't find any issue.

But of course noticed another one: While in tool mode (crop, redeye) zooming by mouse wheel does not work.

rkflx added a comment.Jul 23 2018, 7:47 AM

Thanks for the review!

In D14269#296000, @muhlenpfordt wrote:

But of course noticed another one: While in tool mode (crop, redeye) zooming by mouse wheel does not work.

You only noticed this now? ;) This has been annoying me ever since testing any of the Crop patches. Unfortunately, in this case I did not yet get around to look into it. Feel free to work on it…

Closed by commit R260:1ce062a458b1: Fix image smoothing sometimes not getting applied (authored by rkflx). · Explain WhyJul 24 2018, 6:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38289

View Options

lib/documentview/rasterimageview.cpp

Loading...