Differential D14266

Improve actions_tutorial doc
ClosedPublic
Actions

Authored by szafar on Jul 21 2018, 6:11 PM.

Details

Reviewers
yurchor
asensi
Group Reviewers
Krusader
Commits
R167:b82c8eed300d: Improve actions_tutorial doc
R167:20cc78118f6f: Improve actions_tutorial doc
R167:6b7398fc6048: Improve actions_tutorial doc
Summary

Fix typos, Improve English, Update actions fields, etc.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
szafar requested review of this revision.Jul 21 2018, 6:11 PM
szafar created this revision.
szafar edited the summary of this revision. (Show Details)Jul 21 2018, 6:12 PM
szafar added a project: Krusader.
szafar added a subscriber: Krusader.
yurchor requested changes to this revision.Jul 21 2018, 6:21 PM
yurchor added a subscriber: yurchor.

Thanks! Just a few minor corrections please.

doc-extras/actions_tutorial.txt
20

exists -> exist

40

addesses -> addresses

65–66

for a some -> for some

This revision now requires changes to proceed.Jul 21 2018, 6:21 PM
szafar updated this revision to Diff 38185.Jul 21 2018, 6:24 PM
  • Improve English in actions_tutorial doc
yurchor accepted this revision as: yurchor.Jul 21 2018, 6:25 PM
asensi accepted this revision as: asensi.Jul 22 2018, 5:56 PM
asensi added a subscriber: asensi.

Thanks, Shadab, now the tutorial is better :-)

Thinking about it, as you utilize Krusader's useractions, you can comment in Correct the tab order in the Manage User Actions dialog

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2018, 7:57 AM
Closed by commit R167:b82c8eed300d: Improve actions_tutorial doc (authored by szafar, committed by yurchor). · Explain Why
This revision was automatically updated to reflect the committed changes.
szafar added a comment.EditedJul 25 2018, 3:49 PM

When I created these commits on my local machine, they were committed with git as:
Author: Shadab Zafar <dufferzafar0@gmail.com>

But, now the commits are showing up in git as:
Author: Shadab Zafar <szafar@gmail.com>

I don't own that email address and have no clue where it came from.

Is there a way I can fix this for my future commits?

@yurchor

yurchor added a comment.Jul 25 2018, 3:51 PM
In D14266#297927, @szafar wrote:

When I created these commits on my local machine, they were committed with git as:
Author: Shadab Zafar <dufferzafar0@gmail.com>

But, now the commits are showing up in git as:
Author: Shadab Zafar <szafar@gmail.com>

I don't own that email address and have no clue where it came from.

Is there a way I can fix this for my future commits?

@yurchor

My bad. Sorry. I will use the right address from now on.

Revision Contents
Changeset List

PathPackages
Mdoc-extras/actions_tutorial.txt (72 lines)

Diff 38222

View Options

doc-extras/actions_tutorial.txt

Loading...