GridView pads out its delegate to ensure a uniform grid. This, however, causes items to be placed on fractional pixels, leading to blurry rendering and uneven hinting.
Instead of adjusting padding calculation to return whole pixels, which will again cause a gap at the right side of the screen, since there's 20 icons in a row, slightly shift the delegate contents to move them back to whole pixels.
Moreover, DropShadow renders the entire item with a drop shadow, so keeping the Label visible results in two labels ontop of each other leading to bolder text.
Details
Details
- Reviewers
hein davidedmundson ngraham - Group Reviewers
Plasma - Commits
- R119:5fca2b32ce5b: [Folder View] Improve file name text rendering
- Verified with gamma ray that the Label is now placed at integer scene coordinates
- Font rendering does look a lot nicer, especially in second and lines further down
- Verified that in software rendering Label renders fine just without a shadow
- Verified that label hides when renaming file
- Verified gap at the right of the screen is virtually unchanged
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Looks better with fractional scaling and doesn't regress at all for 1x scaling. Drop shadows are still rendered. Code looks good.
Comment Actions
It kind of sucks we have to do this, we have a lot of different UIs we'd have to copy-paste this fix too, but after a few minutes of mulling I didn't come up with a better idea :/