Correct the tab order in the Manage User Actions dialog
ClosedPublic

Authored by asensi on Jul 19 2018, 10:04 AM.

Details

Summary

To solve the tab order in the Manage User Actions dialog (after trying to move elements (and their labels) in the ui file, which is difficult and makes difficult to compare versions later): I tried the "Edit > Edit Tab Order" option of Qt Creator to edit the tab order, which is much easier, although in order to achieve that, the process adds a tabstops section at the end of the ui file. That tabstops section is much, much simpler to maintain (using Qt Creator or any text editor), and comparing versions is much saner.

If you please, feel free to suggest other options :-)

FIXED: [ 396652 ] In the Manage User Actions dialog: the tab order is not the expected one
BUG: 396652

Notes:

Qt Creator also added a native="true" at the end of widget class="KKeySequenceWidget" name="KeyButtonShortcut". Time ago it was <widget class="KKeySequenceWidget" native="1" name="KeyButtonShortcut" > although it was changed in

commit c8564c6fc974015ceea4f07949b46fbfb41ef29f
Author: Fathi Boudra <fabo@kde.org>, Mon Jun 1 20:18:28 2009 +0000 (9 years ago)
Committer: Fathi Boudra <fabo@kde.org>, Mon Jun 1 20:18:28 2009 +0000 (9 years ago)
Follows: v2.0.0
Precedes: v2.1.0-beta1
Branches: <Expand>

use a KTabWidget in ActionMan property editor

as it can be seen in https://commits.kde.org/krusader/c8564c6fc974015ceea4f07949b46fbfb41ef29f

Test Plan

Launch the Manage User Actions dialog, and try its tab order using the Tab key.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi requested review of this revision.Jul 19 2018, 10:04 AM
asensi created this revision.
asensi updated this revision to Diff 38085.Jul 19 2018, 11:10 AM
asensi edited the summary of this revision. (Show Details)

The tabstops list was changed because "KeyButtonShortcut" was a special case.

asensi edited the summary of this revision. (Show Details)Jul 19 2018, 11:13 AM
asensi edited the summary of this revision. (Show Details)
asensi added a comment.EditedJul 19 2018, 12:51 PM

While we are at it:

Adding this:

<property name="tabChangesFocus">
<bool>true</bool>
</property>

to actionproperty.ui would achieve that, if users pressed Tab when using the KTextEdit named textDescription, then the focus would go to the next control (instead of writing a tab inside the KTextEdit named textDescription, which normally isn't what users want [^1]).

What do you think?

[^1]: "The problem is the tab order gets stuck inside the qtextedit and doesn't move to the buttons when the tab button is clicked. Instead, the tab(s) are entered into the qtextedit."

"when I press tab, a tab space is added to the QTextEdit. How can I change this behavior?"

nmel added a subscriber: nmel.Jul 24 2018, 7:27 AM

... if users pressed Tab when using the KTextEdit named textDescription, then the focus would go to the next control ...

I agree it's a right way. Please add this.

asensi updated this revision to Diff 38321.EditedJul 24 2018, 10:40 AM

> ... if users pressed Tab when using the KTextEdit named textDescription, then the focus would go to the next control ...

I agree it's a right way. Please add this.

Ok! It has been added :-)

szafar added a subscriber: szafar.Jul 25 2018, 3:52 PM

This looks good to me. Have only looked at the changes. Not tested it locally.

nmel accepted this revision.Jul 29 2018, 5:45 AM

Thanks Toni! Works nicely.

This revision is now accepted and ready to land.Jul 29 2018, 5:45 AM
This revision was automatically updated to reflect the committed changes.