Let download update timer only run when there's running downloads
ClosedPublic
Actions

Authored by broulik on Jul 19 2018, 7:48 AM.

Details

Reviewers

davidedmundson
fvogt

Group Reviewers

Plasma

Commits

Summary

Currently we have a 1000ms timer running querying for running downloads whenever the extension is loaded.

Test Plan

Started a download, timer started running, canceled said download, timer stopped running shortly thereafter.
Also works fine with multiple downloads

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jul 19 2018, 7:48 AM

Seems sensible to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2018, 1:54 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			extension/extension.js (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38067			Jul 19 2018, 7:46 AM	★	★
Diff 2	38253	6138ef1	R856:c8b49b565796a3e6c2c7ffaf3791b539d640d3ff	Jul 23 2018, 1:54 PM	★	★