Differential D14224

Make kcm size hint bigger
AbandonedPublic
Actions

Authored by gladhorn on Jul 19 2018, 7:32 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Summary

This makes the kcm look less cramped when running kcm_shell.

Diff Detail

Repository
R104 KScreen
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1000
Build 1013: arc lint + arc unit
gladhorn created this revision.Jul 19 2018, 7:32 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 19 2018, 7:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 19 2018, 7:32 AM
ngraham requested changes to this revision.Jul 19 2018, 8:08 PM
ngraham added a subscriber: ngraham.

This doesn't seem to have the desired effect. Here's how it looks for me without the patch:

And with it:

The window becomes wider, but not any taller, which actually worsens the problem since the top part takes up even more of the view.

This revision now requires changes to proceed.Jul 19 2018, 8:08 PM
gladhorn added a comment.Jul 20 2018, 7:59 AM

I was in general wondering if the KCMs can give sensible size hints somehow. I guess it should be calculated, for me it looks quite different, but scaling and font size play a role.

gladhorn abandoned this revision.Jul 24 2018, 12:50 PM

I'm unsure how to really fix this in a sensible way. Abandoning this for now.

Revision Contents
Changeset List

PathPackages
Mkcm/src/kcm_kscreen.cpp (2 lines)

Diff 38064

View Options

kcm/src/kcm_kscreen.cpp

Loading...