Differential D14209

Listen for player "emptied" signal
ClosedPublic
Actions

Authored by broulik on Jul 18 2018, 2:54 PM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:216d5b12f7d5: Listen for player "emptied" signal
Summary

This is when a website reuses their player and clears its playlist when doing Ajax page navigation

Test Plan

5.13 branch

Fixes stale media controls when watching a YouTube video and then going to the start page.
I get a abort event followed by emptied

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 18 2018, 2:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2018, 2:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 18 2018, 2:54 PM
broulik edited the test plan for this revision. (Show Details)
fvogt added a comment.Jul 18 2018, 2:58 PM

If the extension translates "emptied" to "stopped", wouldn't it be compatible with older hosts?

broulik updated this revision to Diff 38022.Jul 18 2018, 3:02 PM
broulik edited the test plan for this revision. (Show Details)
  • Just emit stopped
fvogt accepted this revision.Jul 18 2018, 3:06 PM

Didn't test myself, but LGTM

This revision is now accepted and ready to land.Jul 18 2018, 3:06 PM
Closed by commit R856:216d5b12f7d5: Listen for player "emptied" signal (authored by broulik). · Explain WhyJul 18 2018, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (7 lines)

Diff 38022

View Options

extension/content-script.js

Loading...