Differential D14207

Also monitor DOM node being removed for player gone
ClosedPublic
Actions

Authored by broulik on Jul 18 2018, 2:08 PM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:09c729554ea1: Also monitor DOM node being removed for player gone
Summary

We currently only monitor the tab being closed or navigating away from the page but when a video overlay opens using JavaScript, we didn't notice that it was gone when the overlay was closed

BUG: 395521

Test Plan

Fixes stale video controls when watching a video on twitter and closing the overlay

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 18 2018, 2:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2018, 2:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 18 2018, 2:08 PM
davidedmundson accepted this revision.Aug 1 2018, 10:25 AM
This revision is now accepted and ready to land.Aug 1 2018, 10:25 AM
Closed by commit R856:09c729554ea1: Also monitor DOM node being removed for player gone (authored by broulik). · Explain WhyAug 1 2018, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (34 lines)

Diff 38016

View Options

extension/content-script.js

Loading...