This time I did not removed the function calls, just
forwarded the calls to the most complete one.
Removing the function calls and adding default parameters
did not seem to work well with dbus
Details
- Reviewers
hindenburg - Group Reviewers
Konsole
Diff Detail
- Repository
- R319 Konsole
- Branch
- simplifySessionHandling
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 967 Build 980: arc lint + arc unit
src/ViewManager.cpp | ||
---|---|---|
1013 | simpler toalso add the , QString() as below? |
I beg your pardon? (How do I test the new session? konsole is working
for me so maybe it's something I missed)
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1 /tmp
and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0
printenv | grep KONSOLE
We set this variable in two or three different files and in a few different
methods. I remember that one of the first things that I tried to do for
konsole was to simplify the creation of sessions (and this broke a lot of
code and you where not happy) but it seems that we do need to make some
compromise and align that.
Em qua, 10 de abr de 2019 às 16:27, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:
hindenburg added a comment. View Revision
https://phabricator.kde.org/D14200In D14200#447412 https://phabricator.kde.org/D14200#447412, @hindenburg
https://phabricator.kde.org/p/hindenburg/ wrote:and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0
Well sometimes it is set and sometimes not
*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D14200*To: *tcanabrava, Konsole, hindenburg
*Cc: *thsurrel, gennad, konsole-devel, ngraham, maximilianocuria,
hindenburg