Differential D14198

Simplify setMainWidget
ClosedPublic
Actions

Authored by tcanabrava on Jul 18 2018, 8:40 AM.

Details

Reviewers
hindenburg
ngraham
Group Reviewers
Konsole
Commits
R319:bf34ae187b6a: Simplify setMainWidget
Summary

There's no need to create a layout for the central widget
that will hold only one widget.

Test Plan

compiled, triggered a few actions that could cause a layout change.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jul 18 2018, 8:40 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 18 2018, 8:40 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 18 2018, 8:40 AM
tcanabrava edited the test plan for this revision. (Show Details)Jul 18 2018, 8:41 AM
tcanabrava added reviewers: Konsole, hindenburg.
tcanabrava abandoned this revision.Aug 28 2018, 3:01 PM

Stale for too long.

tcanabrava reclaimed this revision.Sep 9 2018, 4:19 PM
ngraham accepted this revision.Sep 9 2018, 5:52 PM
ngraham added a subscriber: ngraham.

Indeed.

This revision is now accepted and ready to land.Sep 9 2018, 5:52 PM
Closed by commit R319:bf34ae187b6a: Simplify setMainWidget (authored by tcanabrava). · Explain WhySep 10 2018, 9:19 AM
This revision was automatically updated to reflect the committed changes.
hallas added a subscriber: hallas.Sep 10 2018, 11:38 AM
hallas added inline comments.
src/MainWindow.cpp
24

I think this include can be removed now that the only user of it is gone :)

Revision Contents
Changeset List

PathPackages
Msrc/MainWindow.h (1 line)
Msrc/MainWindow.cpp (17 lines)

Diff 41323

View Options

src/MainWindow.h

Loading...
View Options

src/MainWindow.cpp

Loading...