Enable bionic user edition installation
ClosedPublic

Authored by bshah on Jul 17 2018, 3:27 PM.

Details

Reviewers
sitter
jriddell
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R1005:3319afb9bcac: Enable bionic user edition installation
Summary
  • Add needles for the ubiquity
  • Most of the needles are changed due to font size and small layout

changes

  • installer-disk-confirm-uefi is changed due to bionic not making swap

devices automatically anymore

  • ubiquity changed installer steps so that keyboard layout is configured

before prepare step

  • Only workaround at moment is installer-prepare contains the question

about what kind of install to do, but this is new feature in ubiquity
and needs to be patched out

Not tested yet or WIP:

  • installation offline
  • installation in bios mode
  • installation in OEM mode
  • installation in non-english language
Test Plan

ran locally, CI still seems to stuck on fonts for some reason

Diff Detail

Repository
R1005 Neon OpenQA Components
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.Jul 17 2018, 3:27 PM
Owners added a reviewer: Restricted Owners Package.Jul 17 2018, 3:27 PM
bshah requested review of this revision.Jul 17 2018, 3:27 PM

awesome work. looks good overall. needs some improvements though.

.gitignore
18–19 ↗(On Diff #37962)

kindly land in separate commit ;)

neon/needles/install_ubiquity/bionic/installer-timezone.json
15

missing bionic tag?

neon/needles/install_ubiquity/bionic/installer-user-user.json
15

missing bionic tag?

neon/tests/install_ubiquity.pm
53

comment on why this is necessary please. ideally with ticket/bug uri for fixing this in the long run.
also, please record_soft_failure with the ticket/bug or some description.

75–82

comment on why this is necessary please. ideally with ticket/bug uri for fixing this in the long run.
also, please record_soft_failure with the ticket/bug or some description.

96

reason?

bshah marked an inline comment as done.Jul 18 2018, 10:24 AM
bshah added inline comments.
.gitignore
18–19 ↗(On Diff #37962)

Have separate commit but arc decided to squash it.

neon/needles/install_ubiquity/bionic/installer-timezone.json
15

Will fix

neon/needles/install_ubiquity/bionic/installer-user-user.json
15

Will fix

neon/tests/install_ubiquity.pm
96

Because slideshow had some timing issue or something. I think at first occurrence of slideshow image it didn't match it, so had to give it bit of headroom

bshah updated this revision to Diff 38047.Jul 19 2018, 3:47 AM
bshah marked 10 inline comments as done.
  • Add missing bionic tags
  • record_soft_failure with ticket link for keyboard config
  • remove the .gitignore change from this change.
sitter accepted this revision.Jul 19 2018, 10:04 AM

one nitpick about the forward-compatibility of the code. once that is fixed: lgtm

neon/tests/install_ubiquity.pm
54

should probably be ne 'xenial', seeing as this is the new default moving forward. So this also applies to 20.04 most likely

This revision is now accepted and ready to land.Jul 19 2018, 10:04 AM
This revision was automatically updated to reflect the committed changes.