PyQt>=5.11 uses 'PyQt.sip' sipname by default, but some distributions (such ad Debian) patch it to use 'sip'. Get the sipname from the PyQt configuration instead of setting it depending on the PyQt version.
Details
Uses the correct sipname on Arch with PyQt 5.10 and PyQt 5.11. Needs testing on Debian-based.
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Hm, I'm afraid it doesn't work for me on Neon 18.04:
[100%] Generating krita/sipkritapart0.cpp
sip: Usage: sip [-h] [-V] [-a file] [-b file] [-B tag] [-c dir] [-d file] [-D] [-e] [-f] [-g] [-I dir] [-j #] [-k] [-m file] [-o] [-p module] [-P] [-r] [-s suffix] [-t tag] [-w] [-x feature] [-X id:file] [-y file] [-z file] [@file] [file]
plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita.dir/build.make:93: recipe for target 'plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp' failed
make[2]: * [plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp] Error 1
make[2]: * Deleting file 'plugins/extensions/pykrita/sip/krita/sipkritapart0.cpp'
CMakeFiles/Makefile2:28895: recipe for target 'plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita.dir/all' failed
make[1]: * [plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: * [all] Error 2
boud@boud-ThinkPad-T470p:~/dev/b-krita/plugins/extensions/pykrita/sip$