Differential D14178

Fixes small memory leak in DolphinContextMenu
ClosedPublic
Actions

Authored by hallas on Jul 17 2018, 7:57 AM.

Details

Reviewers
broulik
elvisangelaccio
Commits
R318:f186124f0e2c: Fixes small memory leak in DolphinContextMenu
R318:2cbf3cb11ea6: Fixes small memory leak in DolphinContextMenu
Summary

When DolphinContextMenu::baseFileItem is called a KFileItem is allocated and stored in DolphinContextMenu::m_baseFileItem, which is of type KFileItem*, but the destructor failed to delete this.

Test Plan

This leak was found using Address Sanitizer

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
hallas created this revision.Jul 17 2018, 7:57 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJul 17 2018, 7:57 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
hallas requested review of this revision.Jul 17 2018, 7:57 AM
broulik accepted this revision.Jul 17 2018, 9:36 AM
This revision is now accepted and ready to land.Jul 17 2018, 9:36 AM
ngraham added a subscriber: ngraham.Jul 17 2018, 2:03 PM

Thanks! Can you commit this to the Applications/18.08 branch so we can be sure it gets into the 18.08 release?

elvisangelaccio accepted this revision.Jul 17 2018, 8:55 PM
hallas added a comment.Jul 18 2018, 9:01 AM
In D14178#293741, @ngraham wrote:

Thanks! Can you commit this to the Applications/18.08 branch so we can be sure it gets into the 18.08 release?

How do I do that? I don't think I have commit access, but with the correct guidance I could definitely do it :)

ngraham closed this revision.Jul 18 2018, 10:48 PM

Revision Contents
Changeset List

PathPackages
Msrc/dolphincontextmenu.cpp (2 lines)

Diff 37930

View Options

src/dolphincontextmenu.cpp

Loading...