Use locked cursor position hint
ClosedPublic

Authored by romangg on Jul 17 2018, 12:51 AM.

Details

Summary

Listen for cursor position hint changes and set cursor position to the hint
on unlock if a valid position hint was set.

Test Plan

With pointer constraints test app.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Jul 17 2018, 12:51 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 17 2018, 12:51 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Jul 17 2018, 12:51 AM
graesslin accepted this revision.Jul 17 2018, 2:52 PM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
pointer_input.cpp
600

Coding hint: can be simplified as:
m_lockedPointerHintConnection = {};

This revision is now accepted and ready to land.Jul 17 2018, 2:52 PM
romangg updated this revision to Diff 37972.Jul 17 2018, 4:27 PM
  • Use hint getter

@graesslin Thanks for review, but David wanted me to use a cached variable in KWayland. That's why I had to rework the KWin implementation as well. Sorry. Would appreciate another review for this revision.

graesslin added inline comments.Jul 17 2018, 7:55 PM
pointer_input.cpp
698

const auto

713

I have problems following what's going on here. Maybe add some comments?

romangg updated this revision to Diff 37988.Jul 18 2018, 7:07 AM
  • Add comments, constify
romangg marked 2 inline comments as done.Jul 18 2018, 7:08 AM
This revision was automatically updated to reflect the committed changes.