Differential D14166

Turn OsdManager into a regular class
ClosedPublic
Actions

Authored by gladhorn on Jul 16 2018, 6:53 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R104:58f5bb623d14: Turn OsdManager into a regular class

Summary

The OsdManager was trying to be a singleton while used from only one
place. Simplify it.

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 918
Build 931: arc lint + arc unit

gladhorn created this revision.Jul 16 2018, 6:53 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2018, 6:53 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gladhorn requested review of this revision.Jul 16 2018, 6:53 PM

Harbormaster completed remote builds in B918: Diff 37899.Jul 16 2018, 6:53 PM

davidedmundson accepted this revision.Jul 16 2018, 11:18 PM

This revision is now accepted and ready to land.Jul 16 2018, 11:18 PM

gladhorn added a dependency: D14165: Handle keyboard in action selector OSD.Jul 17 2018, 7:01 PM

Closed by commit R104:58f5bb623d14: Turn OsdManager into a regular class (authored by gladhorn). · Explain WhyJul 18 2018, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kded/daemon.h (1 line)
M			kded/daemon.cpp (10 lines)
M			kded/osdmanager.h (5 lines)
M			kded/osdmanager.cpp (10 lines)
M			tests/osd/osdtest.h (3 lines)
M			tests/osd/osdtest.cpp (14 lines)

Diff 37899

kded/daemon.h

Loading...

kded/daemon.cpp

Loading...

kded/osdmanager.h

Loading...

kded/osdmanager.cpp

Loading...

tests/osd/osdtest.h

Loading...

tests/osd/osdtest.cpp

Loading...