re-add updates by Firas Kraiem
ClosedPublic
Actions

Authored by phanect on Jul 16 2018, 10:44 AM.

Details

Reviewers

winterz
mlaurent

Group Reviewers

KDE PIM
Frameworks

Commits

Summary

The Japanese holiday updates by Firas Kraiem is reverted because it reverts changes done after their commit.

These commits includes changes which Firas really wanted to make.

Repository

R175 KHolidays

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

phanect requested review of this revision.Jul 16 2018, 10:44 AM

phanect retitled this revision from Update substitute holidays & holidays between public holidays to Add .Jul 16 2018, 10:48 AM

phanect edited the summary of this revision. (Show Details)

Please change commit title "Add" by a commit title which explains what your commit will do.
thanks

This revision now requires changes to proceed.Jul 19 2018, 5:58 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Jul 21 2018, 1:30 PM

This revision was automatically updated to reflect the committed changes.

phanect retitled this revision from Add to re-add updates by Firas Kraiem.Jul 21 2018, 4:17 PM

Sorry, my response is too late... I just fixed the title.
Thanks for merge my commits via R175

			Path	Packages
M			holidays/plan2/holiday_jp_en-us (24 lines)
M			holidays/plan2/holiday_jp_ja (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37860	1c2ecfb		Jul 16 2018, 10:44 AM	★	★
Diff 2	38177	1c2ecfb	R175:8c49f9b3dfe2f9b54b160fc415f9338f02c01606	Jul 21 2018, 1:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
17a60e6320f6	8c33e788c2ad	0741e7cbe1cb	Jumpei Ogawa	Update author & last update day in Japan holidays	Jul 1 2018, 12:28 PM
0741e7cbe1cb	821b127fb62d	4811045884ae	Jumpei Ogawa	Fix wrong Japanese holiday name: 元旦 -> 元日 (Show More…)	Jun 30 2018, 3:17 PM
4811045884ae	e699044f6930	1c2ecfbf9570	Jumpei Ogawa	Update substitute holidays & holidays between public holidays (Show More…)	Jun 30 2018, 3:10 PM