This OSD should handle keyboard input and behave different, so make it work on its own.
In follow up changes, the keyboard handling will be added.
CCBUG: 395804
davidedmundson |
Plasma |
This OSD should handle keyboard input and behave different, so make it work on its own.
In follow up changes, the keyboard handling will be added.
CCBUG: 395804
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
kded/osd.cpp | ||
---|---|---|
119 | Please delete reference. Compilers can eliminate unnecessary copying, so there is no need to do the lifetime expansion. |
kded/osd.cpp | ||
---|---|---|
119 | s/expansion/extension/ |
kded/osd.cpp | ||
---|---|---|
119 | Good point. I copied this from the original instantiation, will fix both. |
kded/osd.cpp | ||
---|---|---|
149 | Ouch, there you saved me :) osdtest works since it exits, with the real osd through kded it doesn't work at all. |
kded/osd.cpp | ||
---|---|---|
125 | Should we use QmlObjectSharedEngine here? (could be done separately later) | |
139 | This assert can never be hit, you *always* create the object or return early and never end up here | |
kded/qml/OsdSelector.qml | ||
31 | Why initially visible? | |
117 | This looks unrelated to this particular patch ("In follow up changes, the keyboard handling will be added.") |
kded/osd.cpp | ||
---|---|---|
125 | I think the whole OSD class is constantly being deleted/re-created (after 5 seconds of not being used iirc) so for now this is moot. | |
139 | That is correct. Do you prefer not to have the assert? | |
kded/qml/OsdSelector.qml | ||
31 | It doesn't matter, can happily be removed. | |
117 | True, I can take it out, it doesn't work anyway since we don't the focus into the dialog anyway. |
Do not yet introduce any keyboard handling (escape snuck in) and remove clutter (assert, visible:true).
I'd like to get this in since the meaningful changes (keyboard handling) are based on this :)