CSS: update syntax and fix some errors
ClosedPublic

Authored by jpoelen on Jul 15 2018, 3:54 PM.

Details

Summary
  • fix tag followed by a pseudo-class in a nested rule (@media, ...)
  • fix constraint in a rule
  • fix Kate auto-completion for properties and rules

New highlighting categories

  • Keyword
  • Operator
  • Separator Symbol
  • SpecialChar
  • Variable
  • Value Keyword
  • Color
  • Number
  • Unit
  • Selector Tag

Diff Detail

Repository
R216 Syntax Highlighting
Branch
css
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 880
Build 893: arc lint + arc unit
jpoelen created this revision.Jul 15 2018, 3:54 PM
Restricted Application added a project: Kate. · View Herald TranscriptJul 15 2018, 3:54 PM
Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald Transcript
jpoelen requested review of this revision.Jul 15 2018, 3:54 PM
dhaumann accepted this revision.Jul 15 2018, 4:56 PM

Looks like a nice update - thanks for your work. Can you 'arc land' yourself? :-)

This revision is now accepted and ready to land.Jul 15 2018, 4:56 PM
This revision was automatically updated to reflect the committed changes.

It is done. So much emotion :')

Thanks for pushing.

Could you have a quick look at https://build.kde.org and search for "syntax-highlighting"? It seems the unit tests do not pass since this change, probably a minor issue:
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/