Rewrite code for parsing variables and functions names and move it to server side.
Details
Details
Diff Detail
Diff Detail
- Repository
- R55 Cantor
- Branch
- julia-highligt-refactor
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1051 Build 1064: arc lint + arc unit
| src/backends/julia/juliaserver/juliaserver.cpp | ||
|---|---|---|
| 153 | jl_names_function can be defined later when it's needed, after the potential "return" couple of lines below. | |
| 155 | moduleName is only required if module != jl_internal_main_module. So, put this inside of the if-statement. | |
| 211 | m_variables instead of m_foundVariables? | |
| 216 | m_variableValues instead of m_foundVariableValues? | |
| 221 | m_functions instead of m_foundFunctions? | |
| src/backends/julia/juliasession.cpp | ||
| 252 | Add a sanity check for the case when values.size() != variables.size(): if (i>=values.size()) continue; | |
Comment Actions
This doesn't compile with julia 0.4.7
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp: In member function ‘void JuliaServer::parseJlModule(jl_module_t*)’:
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:156:55: error: ‘jl_string_ptr’ was not declared in this scope
const QString& moduleName = QString::fromUtf8(jl_string_ptr(jl_call1(jl_string_function, (jl_value_t*)(module->name))));
^~~~~~~~~~~~~
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:156:55: note: suggested alternative: ‘jl_string_data’
const QString& moduleName = QString::fromUtf8(jl_string_ptr(jl_call1(jl_string_function, (jl_value_t*)(module->name))));
^~~~~~~~~~~~~
jl_string_data
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:171:46: error: ‘jl_string_ptr’ was not declared in this scope
QString name = QString::fromUtf8(jl_string_ptr(jl_call1(jl_string_function, data[i])));
^~~~~~~~~~~~~
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:171:46: note: suggested alternative: ‘jl_string_data’
QString name = QString::fromUtf8(jl_string_ptr(jl_call1(jl_string_function, data[i])));
^~~~~~~~~~~~~
jl_string_data
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:188:66: error: ‘jl_unionall_type’ was not declared in this scope
else if (datetype != jl_datatype_type && datetype != jl_unionall_type)
^~~~~~~~~~~~~~~~
/home/alex/Projekte/cantor/src/backends/julia/juliaserver/juliaserver.cpp:188:66: note: suggested alternative: ‘jl_uniontype_type’
else if (datetype != jl_datatype_type && datetype != jl_unionall_type)
^~~~~~~~~~~~~~~~
jl_uniontype_typeLooks like we need to add additional include(s) containing the declarations of jl_string_ptr and jl_uniontype_type for 0.4.7.