Differential D14131

Add enum alias Property::Language for typo Property::Langauge
ClosedPublic
Actions

Authored by kossebau on Jul 15 2018, 12:06 PM.

Details

Reviewers
mgallien
Commits
R286:0f5a6c892473: Add enum alias Property::Language for typo Property::Langauge
Test Plan

Unit tests still pass, Dolphin still shows the right file metadata

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 15 2018, 12:06 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJul 15 2018, 12:06 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 15 2018, 12:06 PM
aacid added a subscriber: aacid.Jul 18 2018, 10:48 PM

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

mgallien added a comment.Jul 19 2018, 2:26 AM
In D14131#294528, @aacid wrote:

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

I am in holidays for 3 weeks and unable to properly review anything. Sorry.
By the way, is there a KDE wide service to indicate vacancies ?

bcooksley added a subscriber: bcooksley.Jul 19 2018, 6:22 AM

There is no KDE wide service to indicate absences or unavailability at the moment i'm afraid.

kossebau added a comment.Jul 30 2018, 11:20 AM

@mgallien Enjoy your vacations :) Not a pressing issue, just some TODO which could be fixed already now and which I saw while stumpling about the same typo elsewhere. So fine with me to only handle once you are back.

mgallien accepted this revision.Aug 11 2018, 5:24 PM

Thanks for your work and good idea.

This revision is now accepted and ready to land.Aug 11 2018, 5:24 PM
Closed by commit R286:0f5a6c892473: Add enum alias Property::Language for typo Property::Langauge (authored by kossebau). · Explain WhyAug 11 2018, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/properties.h (9 lines)

Diff 39468

View Options

src/properties.h

Loading...