It's mostly rename from reports_testcommon. I think it should be a center place for testing every class in KMM and not only reports.
Details
Details
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Other than that it looks good to me.
| kmymoney/plugins/views/reports/core/tests/pivottable-test.cpp | ||
|---|---|---|
| 53 | filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0'));I know, you just used the old code, but we should improve it while we're at it. | |
| 69 | filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0')); | |
| kmymoney/plugins/views/reports/core/tests/querytable-test.cpp | ||
| 50 | filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0')); | |
| 65 | filename = QString("qreport-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0'));Not sure, if the leading q in the filename is just a typo or really wanted since all others don't have it. | |
Comment Actions
I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.