Fix CMakeLists.txt to work with older versions of CMake
ClosedPublic

Authored by ngraham on Jul 14 2018, 3:19 PM.

Details

Summary

The VERSION_GREATER_EQUAL macro was only introduced with version 3.7, and many distros (including KDE Neon) ship an older version of CMake. This patch restores compatibility with those older versions.

Test Plan

Now I can build Discover again

Diff Detail

Repository
R134 Discover Software Store
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 844
Build 857: arc lint + arc unit
ngraham created this revision.Jul 14 2018, 3:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2018, 3:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 14 2018, 3:19 PM
apol added a comment.Jul 14 2018, 3:59 PM

uh? isn't that the same?

In effect, it's the same. But the VERSION_GREATER_EQUAL macro is only present in newer versions of CMake, which makes it not work in, for example, KDE Neon, which ships with an older version of CMake.

apol accepted this revision.Jul 16 2018, 12:14 PM
This revision is now accepted and ready to land.Jul 16 2018, 12:14 PM
This revision was automatically updated to reflect the committed changes.