Add share action to selection context menu
Needs RevisionPublic

Authored by nicolasfella on Jul 13 2018, 8:39 PM.

Details

Reviewers
aacid
apol
Group Reviewers
Okular
Summary

Enable sharing a selection via Purpose.

Test Plan

Diff Detail

Repository
R223 Okular
Branch
share
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 817
Build 830: arc lint + arc unit
nicolasfella created this revision.Jul 13 2018, 8:39 PM
Restricted Application added a project: Okular. · View Herald TranscriptJul 13 2018, 8:39 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 13 2018, 8:39 PM
nicolasfella edited the test plan for this revision. (Show Details)Jul 13 2018, 8:41 PM
apol added a comment.Jul 16 2018, 4:05 PM

I'd say it would make sense to just make it possible to drag and drop this to the quick share plasmoid. Or just put it on the clipboard and paste it there.

ui/pageview.cpp
60

Purpose is already used in other parts of Okular and it's ifdef'd there.

aacid added a comment.Jul 19 2018, 8:52 PM

I personally don't think this makes much sense, but I'm not a heavy Okular user either.

In D14102#293160, @apol wrote:

I'd say it would make sense to just make it possible to drag and drop this to the quick share plasmoid. Or just put it on the clipboard and paste it there.

You can't drag the selection goes away once the menu goes away.

ui/pageview.cpp
2851

Don't duplicate code that is just 3 lines below, reuse!

aacid requested changes to this revision.Jun 22 2019, 3:00 PM
This revision now requires changes to proceed.Jun 22 2019, 3:00 PM

Yeah I'm not sure how much sense it makes to have this in the selection context menu. I could see it making sense in the File menu though, where it would operate on the active file.

aacid added a comment.Jun 22 2019, 3:23 PM

Yeah I'm not sure how much sense it makes to have this in the selection context menu. I could see it making sense in the File menu though, where it would operate on the active file.

The awesome thing about that is that Limux paid for that, so we already have it :)

Why so we do!