The current HIG page about alignment https://hig.kde.org/layout/alignment.html focuses very heavily on label and input element placement, but is rather light on general rules for alignment of various objects. This patch is moving the label and input element parts to its own content pattern and @abetts
wrote the content for a new, more general alignment page.
Details
Details
- Reviewers
abetts ngraham - Group Reviewers
VDG - Commits
- R985:1eefc656df6a: Refacteored content about alignment and forms
Diff Detail
Diff Detail
- Repository
- R985 KDE Human Interface Guidelines
- Branch
- form
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2346 Build 2364: arc lint + arc unit
| source/layout/alignment.rst | ||
|---|---|---|
| 28 | common ans sensical usage of -> common-sense | |
| 30 | omit -> miss | |
| 38–40 | How about this instead? "Simple: good alignment improves comprehensibility and speed, and demands less thought." | |
| 39 | Hmm, I'm not sure what this sentence is trying to communicate. | |
| 49 | expect similar elements grouped -> expect that similar elements are grouped | |
| 65 | paradox -> paradigm ? Without the following example, I don't think it would be clear what this section is trying to communicate. | |
Comment Actions
Also, the title of this patch needs to follow commit message best practices. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch and https://chris.beams.io/posts/git-commit/#seven-rules
| source/layout/alignment.rst | ||
|---|---|---|
| 38–40 | How about this? "Simple: good alignment improves visual understanding and speed, and allows less thinking" | |
| 39 | I may not have the right words here. What I mean is that when people design, they may have many guides or lines as margins or points of alignment for their objects and that a designer should simplify these. Many do it to jam pack their windows to have as much used space as possible and the UI ends up looking confusing. | |
| 65 | Paradigm is right! | |